Skip to content

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Jul 1, 2020

Issue #, if available:
Done as part of IMDS v2 in JS-1802

Description of changes:
adds arrow functions in ImdsCredentials.ts

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

Codecov Report

Merging #1317 into master will increase coverage by 4.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1317      +/-   ##
==========================================
+ Coverage   73.04%   77.49%   +4.44%     
==========================================
  Files         287      286       -1     
  Lines       12730    11897     -833     
  Branches     2922     2600     -322     
==========================================
- Hits         9299     9219      -80     
+ Misses       3431     2678     -753     
Impacted Files Coverage Δ
packages/region-provider/src/fromEnv.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-json/runtimeConfig.ts 100.00% <0.00%> (ø)
packages/property-provider/src/memoize.ts 100.00% <0.00%> (ø)
protocol_tests/aws-query/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-ec2/EC2ProtocolClient.ts 92.30% <0.00%> (ø)
protocol_tests/aws-restxml/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-restjson/runtimeConfig.ts 100.00% <0.00%> (ø)
protocol_tests/aws-json/JsonProtocolClient.ts 92.30% <0.00%> (ø)
packages/middleware-retry/src/configurations.ts 100.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85866ff...eea61bf. Read the comment docs.

@trivikr trivikr changed the title chore(credential-provider-imds): arrow functions in ImdsCredentials chore(credential-provider-imds): arrow fn in ImdsCredentials Jul 2, 2020
@trivikr trivikr merged commit 8b1afc6 into aws:master Jul 2, 2020
@trivikr trivikr deleted the ImdsCredentials-arrow-functions branch July 2, 2020 16:10
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants