Skip to content

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Jul 8, 2020

Issue #, if available:
N/A

Description of changes:
bump typescript to ~3.9.3

new build (post git clean -dfx and yarn):

$ typescript ~3.8.3
Done in 381.79s.
yarn build:all  5200.27s user 191.69s system 1411% cpu 6:21.92 total

$ typescript ~3.9.3
Done in 347.24s.
yarn build:all  4770.80s user 183.97s system 1426% cpu 5:47.37 total

repeat build

$ typescript ~3.8.3
Done in 113.29s.
yarn build:all  1467.44s user 90.27s system 1373% cpu 1:53.42 total

$ typescript ~3.9.3
Done in 115.64s.
yarn build:all  1499.69s user 90.40s system 1373% cpu 1:55.77 total

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2020

Codecov Report

Merging #1347 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1347      +/-   ##
==========================================
+ Coverage   77.67%   77.68%   +0.01%     
==========================================
  Files         286      287       +1     
  Lines       11955    11976      +21     
  Branches     2623     2631       +8     
==========================================
+ Hits         9286     9304      +18     
- Misses       2669     2672       +3     
Impacted Files Coverage Δ
.../middleware-sdk-transcribe-streaming/src/signer.ts 80.00% <100.00%> (ø)
packages/url-parser-node/src/index.ts 100.00% <0.00%> (ø)
...s/middleware-bucket-endpoint/src/bucketHostname.ts 100.00% <0.00%> (ø)
...s/middleware-bucket-endpoint/src/configurations.ts 100.00% <0.00%> (ø)
...er-cognito-identity/src/fromCognitoIdentityPool.ts 100.00% <0.00%> (ø)
packages/middleware-stack/src/MiddlewareStack.ts 88.66% <0.00%> (+0.05%) ⬆️
packages/signature-v4/src/moveHeadersToQuery.ts 92.30% <0.00%> (+1.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea01dd8...6c117eb. Read the comment docs.

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! Do you need to update the codegen?

@trivikr
Copy link
Member Author

trivikr commented Jul 10, 2020

Do you need to update the codegen?

Yup, will update codegen with all deps updates in a separate PR.
We should ideally accompany codegen updates in deps updates PRs, but most deps updates are done by depenedabot. May be we should prioritize moving clients to a separate repo to simplify ownership.

@trivikr trivikr merged commit 36cb5ca into aws:master Jul 10, 2020
@trivikr trivikr deleted the typescript-upgrade branch July 10, 2020 17:35
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants