fix: increase cucumber default timeout to 300s #1348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1348 +/- ##
=======================================
Coverage 77.67% 77.67%
=======================================
Files 286 287 +1
Lines 11955 11970 +15
Branches 2623 2626 +3
=======================================
+ Hits 9286 9298 +12
- Misses 2669 2672 +3
Continue to review full report at Codecov.
|
AllanZhengYP
approved these changes
Jul 8, 2020
Member
Author
|
Verified that integration tests are successful: $ AWS_PROFILE=team yarn test:integration-legacy
yarn run v1.22.4
$ cucumber-js --fail-fast
.................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
153 scenarios (153 passed)
534 steps (534 passed)
0m57.708s
Done in 60.86s. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Internal JS-1910
Description of changes:
Increase cucumber default timeout to 300s as some integration tests are failing intermittently
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.