Skip to content

Conversation

@JordonPhillips
Copy link
Member

@JordonPhillips JordonPhillips commented Feb 8, 2021

Issue

n/a

Description

This updates the gradle build scripts to allow for publishing of the AWS protocol generators. Most of the java stuff had to be pulled up to the root since the maven plugin requires it to be there, but the actual contents haven't changed aside from javadoc getting run.

Testing

Ran a clean build that succeeded.

Additional context

This isn't actually forcing you to publish to maven, just making it possible. In the short term it enables publishing to maven local so that somebody could run the AWS generators outside of this repo if the locally published the generator first.

The license copy is there because we need one under the java project root to be included in the built jar


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@JordonPhillips JordonPhillips force-pushed the enable-publishing-generators branch from 4992fc7 to f5be576 Compare February 8, 2021 15:03
@JordonPhillips JordonPhillips added contribution/core This is a PR that came from AWS. pr/needs-review This PR needs a review from a Member. labels Feb 8, 2021
@JordonPhillips
Copy link
Member Author

The above seem to be because I had to edit the commit to match the expected title format, and thus the commit it was looking for got removed. I'm assuming it'll kick off another build

Base automatically changed from master to main February 22, 2021 19:46
This updates the gradle build scripts to allow for publishing of
the AWS protocol generators. Most of the java stuff had to be pulled
up to the root since the maven plugin requires it to be there.
@JordonPhillips JordonPhillips force-pushed the enable-publishing-generators branch from f5be576 to 027a78f Compare February 24, 2021 17:53
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 027a78f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@3059f55). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2005   +/-   ##
=======================================
  Coverage        ?   79.45%           
=======================================
  Files           ?      366           
  Lines           ?    15324           
  Branches        ?     3310           
=======================================
  Hits            ?    12176           
  Misses          ?     3148           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3059f55...027a78f. Read the comment docs.

Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp approval.

@AllanZhengYP
Copy link
Contributor

This one will need a review from @kstich

@JordonPhillips JordonPhillips merged commit df525b7 into aws:main Mar 12, 2021
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. pr/needs-review This PR needs a review from a Member.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants