-
Notifications
You must be signed in to change notification settings - Fork 647
chore: Enable publishing of the aws generator #2005
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Enable publishing of the aws generator #2005
Conversation
4992fc7 to
f5be576
Compare
|
The above seem to be because I had to edit the commit to match the expected title format, and thus the commit it was looking for got removed. I'm assuming it'll kick off another build |
This updates the gradle build scripts to allow for publishing of the AWS protocol generators. Most of the java stuff had to be pulled up to the root since the maven plugin requires it to be there.
f5be576 to
027a78f
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov Report
@@ Coverage Diff @@
## main #2005 +/- ##
=======================================
Coverage ? 79.45%
=======================================
Files ? 366
Lines ? 15324
Branches ? 3310
=======================================
Hits ? 12176
Misses ? 3148
Partials ? 0 Continue to review full report at Codecov.
|
AllanZhengYP
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber-stamp approval.
|
This one will need a review from @kstich |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
n/a
Description
This updates the gradle build scripts to allow for publishing of the AWS protocol generators. Most of the java stuff had to be pulled up to the root since the maven plugin requires it to be there, but the actual contents haven't changed aside from javadoc getting run.
Testing
Ran a clean build that succeeded.
Additional context
This isn't actually forcing you to publish to maven, just making it possible. In the short term it enables publishing to maven local so that somebody could run the AWS generators outside of this repo if the locally published the generator first.
The license copy is there because we need one under the java project root to be included in the built jar
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.