Skip to content

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Feb 22, 2021

Issue

Refs: aws/aws-codebuild-docker-images#400

Description

use runtime-versions nodejs in buildspec, as it's updated in ubuntu/standard/4.0/Dockerfile

Testing

Verify that CI is successfully run.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr force-pushed the use-runtime-versions-nodejs branch from 14ff5c2 to b4d1293 Compare February 22, 2021 20:17
@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: b4d1293
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr requested a review from alexforsyth February 23, 2021 19:00
Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trivikr trivikr merged commit 48cbebe into aws:main Feb 24, 2021
@trivikr trivikr deleted the use-runtime-versions-nodejs branch February 24, 2021 20:15
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants