Skip to content

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Mar 19, 2021

Issue

Refs: smithy-lang/smithy-typescript#290

Description

The fast-xml-parser was pinned to v3.17.4 as the project switched to modified MIT License in >=3.17.5 in NaturalIntelligence/fast-xml-parser@5d4e951

The license is now updated to MIT in 3.19.0

Testing

CI and protocol_tests


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr trivikr changed the title chore: pin fast-xml-parser to 3.19.0 chore(deps): pin fast-xml-parser to 3.19.0 Mar 19, 2021
@trivikr trivikr force-pushed the fast-xml-parser-3.19.0 branch from dd57d1f to c892667 Compare March 19, 2021 20:01
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@456002c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2157   +/-   ##
=======================================
  Coverage        ?   78.92%           
=======================================
  Files           ?      380           
  Lines           ?    16201           
  Branches        ?     3515           
=======================================
  Hits            ?    12787           
  Misses          ?     3414           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 456002c...c892667. Read the comment docs.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: c892667
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trivikr trivikr merged commit 5526743 into aws:main Mar 22, 2021
@trivikr trivikr deleted the fast-xml-parser-3.19.0 branch March 22, 2021 15:13
@github-actions
Copy link

github-actions bot commented Apr 6, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants