Skip to content

Conversation

@trivikr
Copy link
Member

@trivikr trivikr commented Mar 24, 2021

Issue

Follow-up to:

Description

This PR moves types to dist folder for the following reasons so that only dist folder can be ignored in:

The dist folder already contains cjs and es folders which contains commonjs and es output. the types folder will now contain types.

Testing

CI


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: afcd144
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@alexforsyth alexforsyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@trivikr trivikr merged commit 012a48b into aws:main Mar 24, 2021
@trivikr trivikr deleted the move-types-dist branch March 24, 2021 17:28
trivikr added a commit to trivikr/aws-sdk-js-v3 that referenced this pull request Mar 24, 2021
@github-actions
Copy link

github-actions bot commented Apr 8, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants