fix(cloudfront-signer): skip extended encoding for query parameters in the base url #7515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
benclarkmck
changed the title
…meters in the base url
benclarkmck
force-pushed
the
fix-cloudfront-signer-encoding
branch
from
a617d7c to
cb471d9
Compare
benclarkmck
changed the title
kuhe
approved these changes
Nov 21, 2025
trivikr
approved these changes
Nov 21, 2025
Member
|
Build failure is OK. I confirmed that unit tests are successful. |
trivikr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#7470
#7437 (comment)
Description
using the extended encoding encodes characters that do not need to be encoded, resulting in invalid signed urls
Testing
Updated the unit test
Manually tested against an internal app that is currently broken with the latest version
Additional context
I was not sure if the extended encoding is important or not for the cloudfront parameters that get added, so I've left it there (line 143), I suspect though that it's unnecessary but have no idea how to confirm
Checklist
*.integ.spec.ts). (N/A)@publictag and enable doc generation on the package? (N/A)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.