misc: gradle mirror #1486

0marperez · 2025-01-06T20:21:12Z

Issue #

Description of changes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

github-actions · 2025-01-06T20:30:38Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK

github-actions · 2025-01-07T16:02:38Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)

ianbotsf · 2025-01-07T18:33:07Z

.github/workflows/codebuild-ci.yml

+      - name: Configure Gradle
+        run: gradle wrapper --gradle-distribution-url ${{ secrets.CUSTOM_GRADLE_DISTRIBUTION_URL }}/gradle-8.5-bin.zip


Suggestion: All this repetition means we'll have to update the version number in a bunch of places. This seems like a good candidate for either a custom action or possibly integrating into our common build setup.

Even better, add the custom action to aws-kotlin-repo-tools like I did for kat

That would hamper our ability to upgrade Gradle versions independently across the repos. Couldn't that also cause issues that wouldn't be caught until the next run of CI?

Great suggestion, thanks

It would be caught when you go to upgrade the version of aws-kotlin-repo-tools you're using

I think I can turn it into an action with inputs to specify the gradle version we want to use. That way we can move it to repo tools

Specify the Gradle version where? In each action that uses Gradle? Doesn't that defeat the goal of commonizing the version in a single place?

Oh you're right, nvm

ianbotsf · 2025-01-07T18:33:41Z

.github/workflows/codebuild-ci.yml

+      - name: Configure Gradle
+        run: gradle wrapper --gradle-distribution-url ${{ secrets.CUSTOM_GRADLE_DISTRIBUTION_URL }}/gradle-8.5-bin.zip


Question: Why make the distribution URL a secret?

I think someone could use it and possibly perform some sort of attack. I doubt someone will but theoretically they could take down our CI or just run up our AWS bill

I think the full command (and the Gradle distribution URL) will still be visible in the CI's logs

I see it hidden as ***

Moving conversation offline.

ianbotsf · 2025-01-07T18:34:34Z

tests/integration-tests/ecs-credentials/gradle/wrapper/gradle-wrapper.properties

 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-7.2-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.5-bin.zip


Question: Why standardize on 8.5? Why not use the latest release, 8.12?

Iirc there are some soon to be deprecated features we're using. I'll try using 8.12 and see if everything works okay

Looks like it works👍

github-actions · 2025-01-07T22:44:24Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)

github-actions · 2025-01-10T17:18:54Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)

github-actions · 2025-01-10T17:33:32Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)

github-actions · 2025-01-10T18:39:30Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)

… gradle-mirror

github-actions · 2025-01-10T19:46:00Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)

github-actions · 2025-01-10T20:43:06Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)

This reverts commit 053fe7a.

This reverts commit 6c00a70.

This reverts commit 6f9e46b.

github-actions · 2025-01-15T18:13:27Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)

github-actions · 2025-01-15T18:19:10Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)

… gradle-mirror

github-actions · 2025-01-15T23:37:29Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK

github-actions · 2025-01-17T18:43:07Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)

ianbotsf · 2025-01-17T19:48:51Z

examples/gradle/wrapper/gradle-wrapper.properties

-distributionUrl=https\://services.gradle.org/distributions/gradle-8.10-bin.zip
+# Keep gradle version in sync with aws-sdk-kotlin/gradle/wrapper/gradle-wrapper.properties
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.12-bin.zip


Nit: Extraneous \ in URL. Applies to other gradle-wrapper.properties files in this PR too.

github-actions · 2025-01-17T20:32:25Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)

… gradle-mirror

sonarqubecloud · 2025-02-04T21:53:00Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2025-02-04T22:03:07Z

A new generated diff is ready to view.

No codegen difference in the AWS SDK

github-actions · 2025-02-04T22:16:13Z

Affected Artifacts

No artifacts changed size

* fix: enhance smoke test debuggability by echoing build output from inner Gradle runner (#1519) * misc: gradle mirror (#1486) * feat: improve coding style of DDBMapper auto-generated schemas (#1522) * misc: bump build plugin version (#1525) * chore: version bump (#1527) * chore: removing unused ECS container credentials integration test (#1509) --------- Co-authored-by: Ian Botsford <83236726+ianbotsf@users.noreply.github.com> Co-authored-by: 0marperez <60363173+0marperez@users.noreply.github.com> Co-authored-by: Matas <lauzmata@amazon.com>

0marperez added 2 commits January 6, 2025 15:05

misc: gradle mirror

a3ccdbb

fix: use different gradle versions

3f70567

0marperez added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Jan 6, 2025

This comment has been minimized.

Sign in to view

0marperez marked this pull request as ready for review January 6, 2025 21:00

0marperez requested a review from a team as a code owner January 6, 2025 21:00

0marperez added 5 commits January 7, 2025 10:40

fix: only use mirror in ci

2c4b6c1

fix: use public gradle distro url when not in ci

f3b4700

fix: use proper working dir in CI

4a48e1d

fix: avoid configuring working-directory where not needed

083a903

fix: left over working dir config from codebuild ci

49527a1

This comment has been minimized.

Sign in to view

ianbotsf reviewed Jan 7, 2025

View reviewed changes

fix: pull request feedback

8febb3b

0marperez added 3 commits January 10, 2025 11:57

misc: possible fix

4117e05

misc: pwd && ls becasue action can't be found

a7f56ee

misc: add working dir to test

6e86682

0marperez added 2 commits January 10, 2025 12:26

pwd and ls again

53bbeb0

fix: use working directory

8aefd49

fix: possible fixes

d63c671

This comment has been minimized.

Sign in to view

0marperez added 2 commits January 10, 2025 14:38

Merge branch 'main' of https://github.com/awslabs/aws-sdk-kotlin into…

18e7f96

… gradle-mirror

possible fix for lint & adding custom URL to service check batch

5736050

fix: use working dir for every run

053fe7a

0marperez added 5 commits January 15, 2025 12:51

Revert "fix: use working dir for every run"

271ed74

This reverts commit 053fe7a.

Revert "fix: configure path when checking out in codebuild CI"

2670696

This reverts commit 6c00a70.

Revert "fix: use checkout sources v4 in codebuild CI"

6f1e46e

This reverts commit 6f9e46b.

misc: hardcode configure gradle task

2a28159

fix: add working directories

c4e11d5

This comment has been minimized.

Sign in to view

0marperez added 4 commits January 15, 2025 16:57

fix: add missing working directory

b52f293

Merge branch 'main' of https://github.com/awslabs/aws-sdk-kotlin into…

beafa42

… gradle-mirror

Merge branch 'main' of https://github.com/awslabs/aws-sdk-kotlin into…

5093d3e

… gradle-mirror

misc: trigger CI

4ced053

This comment has been minimized.

Sign in to view

feat: use action

0c0cd7d

ianbotsf approved these changes Jan 17, 2025

View reviewed changes

fix: remove wrapper changes

f1c6672

0marperez force-pushed the gradle-mirror branch from 695116a to f1c6672 Compare January 17, 2025 20:09

fix: pr feedback

b39f377

Merge branch 'main' of https://github.com/awslabs/aws-sdk-kotlin into…

5c98b5e

… gradle-mirror

0marperez merged commit f9add36 into main Feb 5, 2025
19 checks passed

0marperez deleted the gradle-mirror branch February 5, 2025 14:23

		- name: Configure Gradle
		run: gradle wrapper --gradle-distribution-url ${{ secrets.CUSTOM_GRADLE_DISTRIBUTION_URL }}/gradle-8.5-bin.zip

misc: gradle mirror #1486

misc: gradle mirror #1486

Uh oh!

Conversation

0marperez commented Jan 6, 2025

Issue #

Description of changes

Uh oh!

github-actions bot commented Jan 6, 2025

Uh oh!

This comment has been minimized.

github-actions bot commented Jan 7, 2025

Uh oh!

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0marperez Jan 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 7, 2025

Uh oh!

github-actions bot commented Jan 10, 2025

Uh oh!

github-actions bot commented Jan 10, 2025

Uh oh!

github-actions bot commented Jan 10, 2025

Uh oh!

This comment has been minimized.

github-actions bot commented Jan 10, 2025

Uh oh!

github-actions bot commented Jan 10, 2025

Uh oh!

github-actions bot commented Jan 15, 2025

Uh oh!

github-actions bot commented Jan 15, 2025

Uh oh!

This comment has been minimized.

github-actions bot commented Jan 15, 2025

Uh oh!

This comment has been minimized.

github-actions bot commented Jan 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 17, 2025

Uh oh!

sonarqubecloud bot commented Feb 4, 2025

Quality Gate passed

Uh oh!

github-actions bot commented Feb 4, 2025

Uh oh!

0marperez Jan 7, 2025 •

edited

Loading