misc: enable disabled kotlin native tests #1593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0marperez
added
the
no-changelog
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
0marperez
added
the
acknowledge-artifact-size-increase
This comment has been minimized.
This comment has been minimized.
lauzadis
approved these changes
May 9, 2025
| ] | ||
| """ | ||
|
|
||
| internal fun runRegionProviderChainTestSuite(testSuite: String) = runTest { |
There was a problem hiding this comment.
style: using runTest without a @Test annotation feels weird. Can this just be runBlocking?
Comment on lines
120
to
126
| data class RegionProviderChainTest( | ||
| val name: String, | ||
| val platformProvider: TestPlatformProvider, | ||
| val instanceMetadataProvider: TestInstanceMetadataProvider, | ||
| val region: String?, | ||
| val targets: List<String> = emptyList(), | ||
| ) |
There was a problem hiding this comment.
nit/style: Did this data class and other utility functions need to be moved into this function for some reason? I think it hurts readability
|
|
A new generated diff is ready to view.
|
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description of changes
executeCommand#1592By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.