fix(rt): import signing test suite #451
Conversation
|
A new generated diff is ready to view: __generated-main...__generated-fix-signing |
| @Test | ||
| fun testSigv4TestSuiteHeaders() { | ||
| assertTrue(testSuiteDir.isDirectory) | ||
|
|
||
| val tests = testDirs.map { dir -> | ||
| try { | ||
| val req = getRequest(dir) | ||
| val sreq = getSignedRequest(dir) | ||
| val config = getSigningConfig(dir) ?: DefaultTestSigningConfig | ||
| Sigv4TestSuiteTest(dir, req, sreq, config.build()) | ||
| } catch (ex: Exception) { | ||
| println("failed to get request from $dir: ${ex.message}") | ||
| throw ex | ||
| } | ||
| } | ||
|
|
||
| testSigv4Middleware(tests) | ||
| } | ||
|
|
||
| @Test | ||
| fun testSigv4TestSuiteQuery() { | ||
| assertTrue(testSuiteDir.isDirectory) | ||
|
|
||
| val tests = testDirs.map { dir -> | ||
| try { | ||
| val req = getRequest(dir) | ||
| val sreq = getQuerySignedRequest(dir) | ||
| val config = getSigningConfig(dir) ?: DefaultTestSigningConfig | ||
| config.signatureType = AwsSignatureType.HTTP_REQUEST_VIA_QUERY_PARAMS | ||
| Sigv4TestSuiteTest(dir, req, sreq, config.build()) | ||
| } catch (ex: Exception) { | ||
| println("failed to get request from $dir: ${ex.message}") | ||
| throw ex | ||
| } | ||
| } | ||
|
|
||
| testSigv4Middleware(tests) | ||
| } |
|
A new generated diff is ready to view: __generated-main...__generated-fix-signing |
| .walkTopDown() | ||
| .filter { !it.isDirectory && it.name == "request.txt" } | ||
| .filterNot { it.parentFile.name in disabledTests } | ||
| // .filter{ it.parentFile.name == "get-vanilla-query-order-key-case" } |
| // re-enable after https://github.com/awslabs/aws-crt-java/pull/419 is merged | ||
| "get-vanilla-utf8-query", | ||
|
|
||
| // fixme - revisit why this fails |
There was a problem hiding this comment.
question
does this need more context if someone else digs into it?
There was a problem hiding this comment.
no I don't think so. I think it will be fixed after the other utf8 issue is fixed but if not it's just a matter of diving into the results.
| */ | ||
| private fun testSigv4Middleware(tests: Sequence<Sigv4TestSuiteTest>): Unit = runBlocking { | ||
| tests.forEach { test -> | ||
| // println("running sigv4 middleware test for: ${test.path}") |
|
Kudos, SonarCloud Quality Gate passed!
|
|
A new generated diff is ready to view: __generated-main...__generated-fix-signing |
1 similar comment
|
A new generated diff is ready to view: __generated-main...__generated-fix-signing |
3 participants
Issue #
fixes #448
Description of changes
aws-c-authsigning test suite. This at least gives us some confidence that what comes out of the signing process is a valid signed request. Any signing issues after this point should theoretically be limited to issues with a particular HTTP engine implementation and their ability to serialize the request on the wire in the expected format.HttpRequestBuilder -> CrtRequest -> HttpRequestBuilderto only append new/missing keys for headers and query params rather than overwrite. Previously (as described in the ticket) we would just overwrite all the headers and query params from the signed request. CRT request uses the encoded representation of a request which causes (e.g.) any url encoded parameters to get encoded twice when finally going out on the wire.There are a lot of new files here, most of the relevant changes are in these files:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.