Skip to content

Conversation

@ianbotsf
Copy link
Contributor

Issue #

(none)

Description of changes

Our Maven properties on published service clients aren't currently very useful. For example, with route53recoverycluster-jvm, note that the description of the package is "AWS SDK codegen tasks".

This change sets the package description to "The AWS Kotlin client for " (e.g., "The AWS Kotlin client for Route53 Recovery Cluster"). It also adds a new Maven property containing the literal SDK ID, which will be useful for later build processes that may need the SDK ID but cannot derive it from the artifact ID (since that's had capitalization and spacing stripped from it).

After this change, the generated Maven POM contains the following new/updated tags in the root project element:

<description>The AWS Kotlin client for Route53 Recovery Cluster</description>
<properties>
  <aws.sdk.id>Route53 Recovery Cluster</aws.sdk.id>
</properties>

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ianbotsf ianbotsf added the no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly. label Nov 30, 2022
@ianbotsf ianbotsf requested a review from a team as a code owner November 30, 2022 19:43
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

A new generated diff is ready to view.

@ianbotsf ianbotsf merged commit b91addc into main Nov 30, 2022
@ianbotsf ianbotsf deleted the chore-service-client-build-props branch November 30, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog Indicates that a changelog entry isn't required for a pull request. Use sparingly.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants