Protocol tests issue 33 #3267
Merged
Protocol tests issue 33 #3267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boblodgett
reviewed
Apr 5, 2024
generator/ServiceClientGeneratorLib/Generators/Marshallers/RestXmlResponseUnmarshaller.tt
Outdated
Show resolved
Hide resolved
| return locationName.ToString(); | ||
| } | ||
| var memberTarget = member.Shape.data[ServiceModel.LocationNameKey]; | ||
| if(member.Shape.data != null && memberTarget != null) |
There was a problem hiding this comment.
member.Shape.data != null doesn't seem needed as you would have referenced a location in a null json object previously and that would have failed. Does the check need to be moved or removed?
There was a problem hiding this comment.
you're right, Member.Shape.data would never actually return null I removed it
dscpinheiro
reviewed
Apr 5, 2024
generator/ServiceClientGeneratorLib/Generators/Marshallers/RestXmlResponseUnmarshaller.tt
Outdated
Show resolved
Hide resolved
generator/ServiceClientGeneratorLib/Generators/Marshallers/RestXmlResponseUnmarshaller.tt
Outdated
Show resolved
Hide resolved
|
There are some additional generated changes that snuck in there. These are files that I didn't push in a different commit. You can ignore those. Once we merge all these in we are going to have to run the generator again anyways. |
boblodgett
approved these changes
Apr 6, 2024
dscpinheiro
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes DOTNET-7357 issue 33.
Issue 33 Issue unmarshalling Xml Responses due to improper handling of "LocationName"MERGE into
protocol-testsfeature branch onlyBuilds on prior PR: #3266
Merge order: 112 (I'm going to start mine from 100 and increment to keep separate from Bo's)
Ticket: DOTNET-7357
Motivation and Context
Testing
N/A - the test cases are the protocol tests. A final dry-run will be done on the
protocol-testsfeature branch once everything is merged into the feature branch.Screenshots (if appropriate)
Types of changes
Checklist
License