-
Notifications
You must be signed in to change notification settings - Fork 867
add completeuploadresponse mapping to turesponse object #4060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: GarrettBeatty/stacked/1
Are you sure you want to change the base?
Conversation
dfea2d8
to
ff96820
Compare
b3572ed
to
fa2c582
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds mapping functionality to convert CompleteMultipartUploadResponse
objects to TransferUtilityUploadResponse
objects in the AWS S3 SDK. This enhances the transfer utility by providing a consistent response interface for multipart upload completions.
- Added
MapCompleteMultipartUploadResponse
method inResponseMapper
class - Implemented comprehensive unit tests to validate the mapping functionality
- Added dev config for patch version increment with appropriate changelog
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
sdk/src/Services/S3/Custom/Transfer/Internal/ResponseMapper.cs |
Added new mapping method to convert CompleteMultipartUploadResponse to TransferUtilityUploadResponse |
sdk/test/Services/S3/UnitTests/Custom/ResponseMapperTests.cs |
Added comprehensive unit tests for the new mapping functionality including null handling scenarios |
generator/.DevConfigs/433a9a6d-b8ea-4676-b763-70711e8288e6.json |
Added dev config for patch version increment |
ff96820
to
838f273
Compare
838f273
to
48947aa
Compare
48947aa
to
01bb712
Compare
01bb712
to
8ed36be
Compare
8ed36be
to
7541f14
Compare
7541f14
to
e39e711
Compare
stack-info: PR: #4060, branch: GarrettBeatty/stacked/2
e39e711
to
c227963
Compare
Stacked PRs:
Description
This change adds a function to map the CompletemultipartUploadResponse to TransferUtilityUploadResponse. This is needed because we eventually need to return
TransferUtilityUploadResponse
as part of the progress listener for multi part upload here #4061Motivation and Context
Testing
Types of changes
Checklist
License