fix silently failing test #4073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GarrettBeatty
commented
Oct 23, 2025
| EventFired = true; | ||
| Console.WriteLine("Lifecycle Event Fired: {0}", typeof(T).Name); | ||
| Validate?.Invoke(eventArgs); | ||
| EventFired = true; // Only set if validation passes |
Contributor
Author
There was a problem hiding this comment.
with this change, i reran the tests and they actually fail now if there is some assertion error. and then once i made the above updates to the test cases they now pass
philasmar
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix silently failing test. the logic in OnEventFired was wrong. it was throwing exception but not failing the test. there was 2 test cases not working related to unseekable streams. the issue was i was expecting transferred bytes to set for unseekable streams but in reality we dont set it (
aws-sdk-net/sdk/src/Services/S3/Custom/Transfer/Internal/MultipartUploadCommand.cs
Line 283 in 3179a71
Probably we can come back to this logic in multipartupload in the future, im not sure why transferredbytes wouldnt be able to be calculated?
Motivation and Context
fix integ test
Testing
ran test locally
Types of changes
Checklist
License