Skip to content

Conversation

@peterrsongg
Copy link
Contributor

…3 to be consistent with all other services.

Description

As part of s3 model generation we are changing the service name sent in metrics for S3 from AmazonS3 to Amazon.S3 to be consistent with every other service. This PR proactively changes all other custom marshallers so that it doesn't appear in future diffs.

Motivation and Context

Testing

Dry run passed

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@peterrsongg peterrsongg marked this pull request as draft November 12, 2025 21:04
@peterrsongg peterrsongg force-pushed the petesong/fix-service-name-s3 branch from d3d906b to 8863627 Compare November 12, 2025 21:32
@peterrsongg peterrsongg marked this pull request as ready for review November 12, 2025 21:32
@peterrsongg peterrsongg merged commit 9ee87d9 into development Nov 13, 2025
3 checks passed
@dscpinheiro dscpinheiro deleted the petesong/fix-service-name-s3 branch November 14, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants