Athena #103
Merged
Athena #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Igor wouldn't be more clear to have another methond like: |
Contributor
Author
|
@danielgoldszmit really make sense split it in two methods. I'm not sure about the name Pandas.ctas_sql_athena because it will suggest a method to execute CTAS in fact and not only use the CTAS as a strategy to fetch the data faster... But I have no better suggestions for now. Let me think more about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #102
1 - Support for empty dataframe for Pandas.read_sql_athena(ctas_approach=True)
2 - Cleaning temp S3 files for Pandas.read_sql_athena(ctas_approach=True)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.