Skip to content

Conversation

@dakra
Copy link
Contributor

@dakra dakra commented Dec 14, 2021

If you try to install aws-data-wrangler with the current Python version 3.10.1 it says
it's not compatible and you only get offered a really old version 0.3.2.

This change makes it compatible with all Python 3.10 versions.

@dakra
Copy link
Contributor Author

dakra commented Dec 14, 2021

I guess it's probably useful to also make a new release then, otherwise it's not possible to install the latest awswrangler with Python 3.10.1 from pypi

@kukushking
Copy link
Contributor

Ah, that makes sense. Thanks!

@kukushking kukushking merged commit 3906402 into aws:main Dec 14, 2021
@jmahlik
Copy link
Contributor

jmahlik commented Dec 15, 2021

Should this be <3.11 instead of <=3.10? It doesn't seem dropping the patch version number will work with poetry generated builds.

Current main branch attempts to install with python 3.10.1. I've had a fair share of run-ins with poetry...

(venv) justin@DESKTOP-6BO96LH:~/projects/aws-data-wrangler$ cat pyproject.toml | grep -e 'python = ">'
python = ">=3.6.2, <=3.10"
(venv) justin@DESKTOP-6BO96LH:~/projects/aws-data-wrangler$ python --version
Python 3.10.1
(venv) justin@DESKTOP-6BO96LH:~/projects/aws-data-wrangler$ python -m pip install .
...
ERROR: Package 'awswrangler' requires a different Python: 3.10.1 not in '<=3.10,>=3.6.2'

# Also fails on the poetry generated artifacts
poetry build 
python -m pip install dist/awswrangler-2.13.0-py3-none-any.whl
ERROR: Package 'awswrangler' requires a different Python: 3.10.1 not in '<=3.10,>=3.6.2'

Editing to allow below 3.11 versions

(venv) justin@DESKTOP-6BO96LH:~/projects/aws-data-wrangler$ cat pyproject.toml | grep -e 'python = ">'
python = ">=3.6.2, <=3.11"
(venv) justin@DESKTOP-6BO96LH:~/projects/aws-data-wrangler$ python --version
Python 3.10.1
(venv) justin@DESKTOP-6BO96LH:~/projects/aws-data-wrangler$ python -m pip install .
...
Successfully built awswrangler

@dakra
Copy link
Contributor Author

dakra commented Dec 15, 2021

🙈 It seems you're right. Sorry about that wrong PR. I made a new one which uses <3.11. #1074
Maybe another question is if we should even specify an upper bound version for Python.
E.g. upgrading to 3.12 shouldn't break 3.11 code etc.

@kukushking
Copy link
Contributor

Thanks folks, confused it with poetry-style tilde dependency e.g. ~3.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants