Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Jan 10, 2022

The way how the AWS Data Wrangler Layer can used within CDK and SAR is
improved.

I opened this PR as a draft to allow discussions on how the description is enough or should be even extended, e.g. to more CDK languages or for using SAM templates as well.

Resolves: #1097

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The way how the AWS Data Wrangler Layer can used within CDK and SAR is
improved.

Resolves: #1097
@jaidisido
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
  • Commit ID: 47505dc
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking
Copy link
Contributor

Thanks for improving the docs! Not quite sure why tests have failed, let me re-run them again.

@jaidisido
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
  • Commit ID: 47505dc
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@ghost
Copy link
Author

ghost commented Jan 11, 2022

Thanks for improving the docs! Not quite sure why tests have failed, let me re-run them again.

Not sure as well. Is there anything I missed or broke?

@jaidisido
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
  • Commit ID: ce49d53
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking
Copy link
Contributor

@RigoIce Nope, it's not related to your change - If you rebase your branch should be fixed now. Thanks!

@jaidisido jaidisido marked this pull request as ready for review January 11, 2022 17:01
@jaidisido jaidisido merged commit 21ee8f6 into aws:main Jan 11, 2022
@jaidisido
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
  • Commit ID: fe02b86
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: Incomplete guidance to CDK layer usage

3 participants