Skip to content

Defaults serde in glue.csv_table_definition #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2020
Merged

Defaults serde in glue.csv_table_definition #124

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c14dbc
Default to OpenCSVSerDe when calling csv_table_definition if serde isn't
JPFrancoia Jan 29, 2020
14bd814
Docstring update for metadata_to_glue method.
JPFrancoia Jan 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions awswrangler/glue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,19 +68,19 @@ def metadata_to_glue(self,
description: Optional[str] = None,
parameters: Optional[Dict[str, str]] = None,
columns_comments: Optional[Dict[str, str]] = None) -> None:
"""
"""Create/update a table in the Glue catalog based on a dataframe.

:param dataframe: Pandas Dataframe
:param path: AWS S3 path (E.g. s3://bucket-name/folder_name/
:param objects_paths: Files paths on S3
:param preserve_index: Should preserve index on S3?
:param partition_cols: partitions names
:param mode: "append", "overwrite", "overwrite_partitions"
:param cast_columns: Dictionary of columns names and Athena/Glue types to be casted. (E.g. {"col name": "bigint", "col2 name": "int"}) (Only for "parquet" file_format)
:param file_format: "csv" or "parquet"
:param database: AWS Glue Database name
:param table: AWS Glue table name
:param path: AWS S3 path (E.g. s3://bucket-name/folder_name/
:param file_format: "csv" or "parquet"
:param partition_cols: partitions names
:param preserve_index: Should preserve index on S3?
:param mode: "append", "overwrite", "overwrite_partitions"
:param compression: None, gzip, snappy, etc
:param cast_columns: Dictionary of columns names and Athena/Glue types to be casted. (E.g. {"col name": "bigint", "col2 name": "int"}) (Only for "parquet" file_format)
:param extra_args: Extra arguments specific for each file formats (E.g. "sep" for CSV)
:param description: Table description
:param parameters: Key/value pairs to tag the table (Optional[Dict[str, str]])
Expand Down Expand Up @@ -292,7 +292,7 @@ def csv_table_definition(table: str,
compressed = False if compression is None else True
sep = extra_args["sep"] if "sep" in extra_args else ","
sep = "," if sep is None else sep
serde = extra_args.get("serde")
serde = extra_args.get("serde", "OpenCSVSerDe")
if serde == "OpenCSVSerDe":
serde_fullname = "org.apache.hadoop.hive.serde2.OpenCSVSerde"
param = {
Expand Down