Forward all pandas kwargs #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorborgest
reviewed
Jan 31, 2020
| ini -= forgotten_bytes | ||
| end -= 1 # Range is inclusive, contrary from Python's List | ||
| bytes_range = "bytes={}-{}".format(ini, end) | ||
| bytes_range = f"bytes={ini}-{end}" |
igorborgest
reviewed
Jan 31, 2020
| :param sql: SQL Query | ||
| :param database: Glue/Athena Database | ||
| :param s3_output: AWS S3 path | ||
| :param s3_output: Amazon S3 path |
igorborgest
reviewed
Jan 31, 2020
| thousands, decimal, lineterminator, quotechar, quoting, escapechar, parse_dates, | ||
| infer_datetime_format, na_values, keep_default_na, na_filter, encoding, converters), | ||
| ) | ||
| proc = mp.Process(target=self._read_csv_once_remote, |
igorborgest
approved these changes
Jan 31, 2020
Contributor
igorborgest
left a comment
igorborgest
left a comment
There was a problem hiding this comment.
Great contribution, thanks @tuliocasagrande!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
We are currently manipulating each pandas.read_csv parameter individually and setting default values in case they were missing. A safer approach would be to forward them and let pandas handle default values.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.