Skip to content

Conversation

@KhueNgocDang
Copy link
Contributor

Feature or Bugfix

  • Feature

Detail

  • I've added a stub file ("awswrangler/s3/_list.pyi") for awswrangler/s3/_list.py. The main purpose is to prevent Pylance and mpy from raising Incompatible types in assignment (expression has type "Union[List[str], Iterator[List[str]]]", variable has type "List[str]") when I type-hinting List[str] for a for just a sample function like belows:
import awswrangler as wr
from typing import List
directory_list: List[str] = wr.s3.list_directories(path="s3://udacity-dend",)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 7133a96
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely, thanks very much!

@malachi-constant malachi-constant self-requested a review July 19, 2022 15:38
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: daf47d0
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido jaidisido merged commit 9aea659 into aws:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants