Skip to content

1454 fix rds data api exception #1457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 19, 2022
Merged

1454 fix rds data api exception #1457

merged 4 commits into from
Jul 19, 2022

Conversation

@kukushking
Copy link
Contributor

@kukushking kukushking commented Jul 18, 2022

Feature or Bugfix

  • Bugfix

Detail

  • rethrow rds api exception
  • fix optional db params in test infra
  • test case

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kukushking kukushking added bug Something isn't working minor release Will be addressed in the next minor release labels Jul 18, 2022
@kukushking kukushking added this to the 2.17.0 milestone Jul 18, 2022
@kukushking kukushking self-assigned this Jul 18, 2022
@kukushking kukushking changed the title 1454 fix rds exception handling 1454 fix rds data api exception handling Jul 18, 2022
@kukushking kukushking changed the title 1454 fix rds data api exception handling 1454 fix rds data api exception Jul 18, 2022
@kukushking kukushking mentioned this pull request Jul 18, 2022
Closed
@malachi-constant
Copy link
Contributor

malachi-constant commented Jul 18, 2022

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 7917504
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking kukushking merged commit 2087b8c into main Jul 19, 2022
@malachi-constant malachi-constant deleted the 1454-fix-rds-exception-handling branch July 20, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaidisido jaidisido jaidisido approved these changes

Assignees

@kukushking kukushking

Labels

bug Something isn't working minor release Will be addressed in the next minor release

Projects

None yet

Milestone

2.17.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kukushking @malachi-constant @jaidisido