Skip to content

Fixes type hint non using direct import from 'multiprocessing' #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Fixes type hint non using direct import from 'multiprocessing' #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions awswrangler/pandas.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import copy
import csv
import multiprocessing as mp
from multiprocessing.connection import Connection as MultiprocessingConnection
from ast import literal_eval
from datetime import date, datetime
from decimal import Decimal
Expand Down Expand Up @@ -270,7 +271,7 @@ def _read_csv_once(session_primitives: "SessionPrimitives", bucket_name: str, ke
return dataframe

@staticmethod
def _read_csv_once_remote(send_pipe: mp.connection.Connection, session_primitives: "SessionPrimitives",
def _read_csv_once_remote(send_pipe: MultiprocessingConnection, session_primitives: "SessionPrimitives",
bucket_name: str, key_path: str, **pd_additional_kwargs):
df: pd.DataFrame = Pandas._read_csv_once(session_primitives=session_primitives,
bucket_name=bucket_name,
Expand Down Expand Up @@ -884,7 +885,7 @@ def _cast_pandas(dataframe: pd.DataFrame, cast_columns: Dict[str, str]) -> pd.Da
return dataframe

@staticmethod
def _data_to_s3_dataset_writer_remote(send_pipe,
def _data_to_s3_dataset_writer_remote(send_pipe: MultiprocessingConnection,
dataframe: pd.DataFrame,
path: str,
partition_cols,
Expand Down Expand Up @@ -1295,7 +1296,7 @@ def read_parquet(self,
return df

@staticmethod
def _read_parquet_paths_remote(send_pipe: mp.connection.Connection,
def _read_parquet_paths_remote(send_pipe: MultiprocessingConnection,
session_primitives: "SessionPrimitives",
path: Union[str, List[str]],
columns: Optional[List[str]] = None,
Expand Down Expand Up @@ -1781,7 +1782,7 @@ def _read_fwf(session_primitives: "SessionPrimitives", bucket_name: str, key_pat
return dataframe

@staticmethod
def _read_fwf_remote(send_pipe: mp.connection.Connection, session_primitives: "SessionPrimitives", bucket_name: str,
def _read_fwf_remote(send_pipe: MultiprocessingConnection, session_primitives: "SessionPrimitives", bucket_name: str,
key_path: str, **pd_additional_kwargs):
df: pd.DataFrame = Pandas._read_fwf(session_primitives=session_primitives,
bucket_name=bucket_name,
Expand Down