disable remove repeated underscores rule from _normalize_name as athena allows it #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorborgest
added
bug
Contributor
|
Hi @tiechengsu, thanks for open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are trying to use pandas.to_redshift function, a columnName has double underscore, like
__dc_timelabelThis internally call to_s3, which is trying to
normalize_columns_names_athena. This ended up with columnNamedc_timelabelin redshift and it's unexpected behavior.The issue is athena actually support repeated underscores, we should not remove it.
disable the rule of remove repeated underscores in function
normalize_columns_names_athenain athena.pyBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.