Skip to content

Redshift Serverless test infrastructure #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2022
Merged

Redshift Serverless test infrastructure #1588

merged 1 commit into from
Sep 12, 2022

Conversation

@cnfait
Copy link
Contributor

@cnfait cnfait commented Sep 9, 2022 •
edited
Loading

Feature or Bugfix

  • Feature

Detail

  • adding a Redshift Serverless workgroup and namespace - both are required to use Redshift Serverless
  • Redshift Serverless uses its own secret in Secrets Manager. it cannot reuse the secret for Redshift as the content differs
  • configuring the VPC to use 3 AZs instead of 2 as this is a requirement for Redshift Serverless

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cnfait cnfait added the dependencies Pull requests that update a dependency file label Sep 9, 2022
@cnfait cnfait self-assigned this Sep 9, 2022
@cnfait cnfait force-pushed the dataapi-serverless-infra branch from 0c98f2c to 6b3093b Compare September 9, 2022 01:07
@malachi-constant
Copy link
Contributor

malachi-constant commented Sep 9, 2022

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 0c98f2c
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

jaidisido
jaidisido approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@jaidisido jaidisido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a reference (e.g. docs url) in the PR description explaining why adding the env details is required when # azs > 3?

@jaidisido
Copy link
Contributor

jaidisido commented Sep 9, 2022

There might also be an issue with the poertry.lock based on the failing CFN nag check...

@cnfait
Copy link
Contributor Author

cnfait commented Sep 9, 2022

Could you please add a reference (e.g. docs url) in the PR description explaining why adding the env details is required when # azs > 3?

Sure, I have added this link:
https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_ec2.Vpc.html#maxazs

@cnfait
Copy link
Contributor Author

cnfait commented Sep 9, 2022 •
edited
Loading

There might also be an issue with the poertry.lock based on the failing CFN nag check...

the lock file actually gets removed in this workflow: https://github.com/aws/aws-sdk-pandas/blob/main/.github/workflows/cfn-nag.yml#L47

it was probably done to work around something. I'm tempted to update the workflow to keep the lock file. I'll open another PR.

@cnfait cnfait force-pushed the dataapi-serverless-infra branch 2 times, most recently from aaf5a07 to 6a7b24b Compare September 9, 2022 15:46
@malachi-constant
Copy link
Contributor

malachi-constant commented Sep 9, 2022

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: aaf5a07
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@cnfait cnfait force-pushed the dataapi-serverless-infra branch from 6a7b24b to a07b267 Compare September 11, 2022 19:44
kukushking
kukushking approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@cnfait cnfait force-pushed the dataapi-serverless-infra branch from a07b267 to be3b685 Compare September 12, 2022 11:34
@cnfait cnfait marked this pull request as ready for review September 12, 2022 11:39
@malachi-constant malachi-constant merged commit 9b89aaf into main Sep 12, 2022
@malachi-constant malachi-constant deleted the dataapi-serverless-infra branch September 12, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kukushking kukushking kukushking approved these changes

@jaidisido jaidisido jaidisido approved these changes

Assignees

@cnfait cnfait

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cnfait @malachi-constant @jaidisido @kukushking