(feat): Add recommendation and get APIs #1866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaidisido
commented
Dec 14, 2022
jaidisido
changed the title
LeonLuttenberger
approved these changes
Dec 14, 2022
kukushking
added a commit
that referenced
this pull request
Dec 15, 2022
* Add data quality module. * Remove copy-paste * Refactor - create package, move ruleset evaluation utils to _utils * [skip ci] Add data_quality.evaluate_ruleset(), result processing TBC * [skip ci] Docstrings * [skip ci] Return normalized evaluation results * [skip ci] Add examples in docstrings && fix typing * [skip ci] Minor - newlines * [skip ci] Add Glue DQ IAM role to test infra * [skip ci] Handle multiple rulesets && add client token * [skip ci] Add update_ruleset * [skip ci] Add pushdownPredicate test case * [skip ci] Minor - add to final statuses * (feat): Add recommendation and get APIs (#1866) * Add recommendation and get APIs * Minor - revert conftest change * Handle edge case in regex * Add missing permission to data quality IAM role * Add Glue Data Quality tutorial. * [skip ci] Set number of workers to 2 to minimize charges * Add more unit tests to increase coverage Co-authored-by: jaidisido <jaidisido@gmail.com> Co-authored-by: Leon Luttenberger <luttenberger.leon@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.