Skip to content

Conversation

@MarcosBernal
Copy link
Contributor

Proposal

I think this behavior is closer to what boto3 api does, since it is not necessary to delete a table to create a new one. In my opinion, the "overwrite" mode should be specified explicitly rather than implicitly.

I find this situation quite problematic when I want to limit the permissions, for instance, to a lambda that will only create tables in glue catalog.

Description of changes

There are changes in two files:

  • awswrangler/catalog.py: behavior when creating a non existing parquet table
  • awswrangler/s3.py: adding optional mode parameter in store_parquet_metadata method

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@igorborgest igorborgest self-assigned this Apr 25, 2020
@igorborgest igorborgest self-requested a review April 25, 2020 19:26
@igorborgest igorborgest added enhancement New feature or request minor release Will be addressed in the next minor release WIP Work in progress labels Apr 25, 2020
@igorborgest igorborgest merged commit a13c55e into aws:master Apr 25, 2020
@igorborgest
Copy link
Contributor

Thanks @MarcosBernal !

@igorborgest igorborgest added WIP Work in progress and removed WIP Work in progress labels Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request minor release Will be addressed in the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants