change _create_table (catalog.py) default behavior to do not remove table if exists #204
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposal
I think this behavior is closer to what boto3 api does, since it is not necessary to delete a table to create a new one. In my opinion, the "overwrite" mode should be specified explicitly rather than implicitly.
I find this situation quite problematic when I want to limit the permissions, for instance, to a lambda that will only create tables in glue catalog.
Description of changes
There are changes in two files:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.