fix: Ignore index for multi-file datasets in distributed mode #2266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kukushking
requested review from
LeonLuttenberger,
cnfait,
jaidisido and
malachi-constant
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
LeonLuttenberger
approved these changes
May 10, 2023
jaidisido
requested changes
May 10, 2023
Contributor
jaidisido
left a comment
jaidisido
left a comment
There was a problem hiding this comment.
We would need to xfail all of these tests in dist mode only:
tests/unit/test_s3_parquet.py::test_index_recovery_partitioned_str
tests/unit/test_s3_parquet.py::test_empty_file
tests/unit/test_s3_parquet.py::test_index_and_timezone
Feel free to merge once that is covered, thanks!
…ts in distributed mode
Contributor
Author
|
Thanks @jaidisido just wanted to let cicd fail to see if only those tests are causing trouble. |
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
jaidisido
approved these changes
May 10, 2023
jaidisido
added a commit
that referenced
this pull request
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detail
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.