Skip to content

Revert "fix: Ignore index for multi-file datasets in distributed mode" #2277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2023
Merged

Revert "fix: Ignore index for multi-file datasets in distributed mode" #2277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion awswrangler/distributed/ray/modin/s3/_read_parquet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,5 +55,5 @@ def _read_parquet_distributed( # pylint: disable=unused-argument
return _to_modin(
dataset=dataset,
to_pandas_kwargs=arrow_kwargs,
ignore_index=bool(path_root),
ignore_index=arrow_kwargs.get("ignore_metadata"),
)
7 changes: 0 additions & 7 deletions tests/unit/test_s3_parquet.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,6 @@ def test_parquet_with_size(path, use_threads, max_rows_by_file):
assert df.iint8.sum() == df2.iint8.sum()


@pytest.mark.xfail(is_ray_modin, raises=AssertionError, reason="Index equality regression")
@pytest.mark.parametrize("use_threads", [True, False, 2])
def test_index_and_timezone(path, use_threads):
df = pd.DataFrame({"c0": [datetime.utcnow(), datetime.utcnow()], "par": ["a", "b"]}, index=["foo", "boo"])
Expand Down Expand Up @@ -397,7 +396,6 @@ def test_index_recovery_simple_str(path, use_threads):
assert_pandas_equals(df, df2)


@pytest.mark.xfail(is_ray_modin, raises=AssertionError, reason="Index equality regression")
@pytest.mark.parametrize("use_threads", [True, False, 2])
def test_index_recovery_partitioned_str(path, use_threads):
df = pd.DataFrame(
Expand Down Expand Up @@ -625,11 +623,6 @@ def test_parquet_compression(path, compression) -> None:
assert_pandas_equals(df, df2)


@pytest.mark.xfail(
is_ray_modin,
raises=AssertionError,
reason="Dataframe indexes are not equal in distributed mode",
)
@pytest.mark.parametrize("use_threads", [True, False, 2])
def test_empty_file(path, use_threads):
df = pd.DataFrame({"c0": [1, 2, 3], "c1": [None, None, None], "par": ["a", "b", "c"]})
Expand Down