Skip to content

fix: Remove packaging & ORC from lambda layer due to layer size limit #2336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 12, 2023
Merged

fix: Remove packaging & ORC from lambda layer due to layer size limit #2336

merged 4 commits into from
Jun 12, 2023

Conversation

@LeonLuttenberger
Copy link
Contributor

@LeonLuttenberger LeonLuttenberger commented Jun 12, 2023 •
edited
Loading

Feature or Bugfix

  • Bugfix

Detail

  • We've breached the 50 MiB Lambda layer size with the addition of the packaging package. This package is not needed since it's already included in the AWS lambda
  • Also removed PyArrow ORC support for lambda layers

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@LeonLuttenberger LeonLuttenberger self-assigned this Jun 12, 2023
kukushking
kukushking approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Let's mention in the release notes pyarrow layer with ORC support will be required to use ORC.

@LeonLuttenberger LeonLuttenberger changed the title fix: Remove ORC support for Lambda Layers due to layer size limit fix: Remove packaging from lambda layer due to layer size limit Jun 12, 2023
kukushking
kukushking requested changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need export PYARROW_WITH_ORC=1 as well?

kukushking
kukushking approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@malachi-constant
Copy link
Contributor

malachi-constant commented Jun 12, 2023

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 5c0a072
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

malachi-constant commented Jun 12, 2023

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: 5c0a072
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

malachi-constant commented Jun 12, 2023

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 5938fa0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

malachi-constant commented Jun 12, 2023

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: 5938fa0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

malachi-constant commented Jun 12, 2023

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 50600c0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

malachi-constant commented Jun 12, 2023

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: 50600c0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@LeonLuttenberger LeonLuttenberger changed the title fix: Remove packaging from lambda layer due to layer size limit fix: Remove packaging & ORC from lambda layer due to layer size limit Jun 12, 2023
@malachi-constant
Copy link
Contributor

malachi-constant commented Jun 12, 2023

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: e9bbfcc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

malachi-constant commented Jun 12, 2023

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: e9bbfcc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@LeonLuttenberger LeonLuttenberger merged commit 288db9f into main Jun 12, 2023
@LeonLuttenberger LeonLuttenberger deleted the fix/pyarrow-orc-lambda-layer branch June 12, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kukushking kukushking kukushking approved these changes

@jaidisido jaidisido Awaiting requested review from jaidisido

@cnfait cnfait Awaiting requested review from cnfait

+1 more reviewer

@malachi-constant malachi-constant malachi-constant approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LeonLuttenberger LeonLuttenberger

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LeonLuttenberger @malachi-constant @kukushking