Skip to content

raise Exception if delete_objects failed #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2020
Merged

raise Exception if delete_objects failed #238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 21 additions & 1 deletion awswrangler/s3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
from boto3.s3.transfer import TransferConfig # type: ignore
from pandas.io.common import infer_compression # type: ignore


from awswrangler import _data_types, _utils, catalog, exceptions

_COMPRESSION_2_EXT: Dict[Optional[str], str] = {None: "", "gzip": ".gz", "snappy": ".snappy"}
Expand Down Expand Up @@ -289,7 +290,26 @@ def _split_paths_by_bucket(paths: List[str]) -> Dict[str, List[str]]:
def _delete_objects(bucket: str, keys: List[str], client_s3: boto3.client) -> None:
_logger.debug("len(keys): %s", len(keys))
batch: List[Dict[str, str]] = [{"Key": key} for key in keys]
client_s3.delete_objects(Bucket=bucket, Delete={"Objects": batch})
res = client_s3.delete_objects(Bucket=bucket, Delete={"Objects": batch})
deleted = res.get('Deleted')
errors = res.get('Errors')
if errors:
for i in errors:
raise exceptions.ServiceApiError(
'Path: s3://{}/{}\n'
'Error Code: {}\n'
'Message: {}'.format(
bucket,
i.get('Key'),
i.get('Code'),
i.get('Message')
)
)
else:
for i in deleted:
_logger.debug(
's3://{}/{} has been deleted'.format(bucket, i.get('Key'))
)


def describe_objects(
Expand Down