Skip to content

Conversation

@igorborgest
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

igorborgest and others added 25 commits May 12, 2020 22:35
…xception_raise

raise Exception if delete_objects failed
* Currently `awswrangler` ensures that at least some boto3 Session is
  used when it calls AWS resources. However, since it creates a
  `boto3.Session()` when non-null boto3 Session is passed as a
  parameter, it completely sidesteps the ability of the user to set
  parameters to the boto3 session that gets used by default (via the
  `boto3.setup_default_session` function).

* This commit ensures that the `ensure_session` function uses boto3's
  default session (reachable via `boto3._get_default_session()`) which
  then also allows `awswrangler` users to set default parameters of the
  boto3 Session it uses by default via `boto3.setup_default_session()`.

Signed-off-by: mr.Shu <mr@shu.io>
_utils: Make sure boto3's default session is used
Add tests to the new default session.
@igorborgest igorborgest self-assigned this May 20, 2020
@igorborgest igorborgest added the minor release Will be addressed in the next minor release label May 20, 2020
@igorborgest igorborgest added this to the 1.2.0 milestone May 20, 2020
@igorborgest igorborgest merged commit 34608fa into master May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor release Will be addressed in the next minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants