Skip to content

fix: readthedocs migration #2499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 25, 2023
Merged

fix: readthedocs migration #2499

merged 10 commits into from
Oct 25, 2023

Conversation

@LeonLuttenberger
Copy link
Contributor

@LeonLuttenberger LeonLuttenberger commented Oct 25, 2023

Feature or Bugfix

  • Feature

Detail

  • Our documentation is no longer building because we didn't perform this migration in time
  • Added the missing build.os and build.tools variables
  • We are currently missing the documentation for release 3.4.1 because it's failing to build

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@LeonLuttenberger LeonLuttenberger self-assigned this Oct 25, 2023
@LeonLuttenberger LeonLuttenberger added the documentation Improvement or bugfixes on docs label Oct 25, 2023
@LeonLuttenberger LeonLuttenberger merged commit 64868b6 into main Oct 25, 2023
@LeonLuttenberger LeonLuttenberger deleted the fix-docs branch October 25, 2023 16:13
@malachi-constant
Copy link
Contributor

malachi-constant commented Oct 25, 2023

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: e9d6012
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

malachi-constant commented Oct 25, 2023

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 265b42e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kukushking kukushking kukushking approved these changes

@malachi-constant malachi-constant Awaiting requested review from malachi-constant

@jaidisido jaidisido Awaiting requested review from jaidisido

@cnfait cnfait Awaiting requested review from cnfait

Assignees

@LeonLuttenberger LeonLuttenberger

Labels

documentation Improvement or bugfixes on docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LeonLuttenberger @malachi-constant @kukushking