Skip to content

refactor naming #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2020
Merged

refactor naming #257

merged 1 commit into from
May 23, 2020

Conversation

@bryanyang0528
Copy link
Contributor

@bryanyang0528 bryanyang0528 commented May 23, 2020

Issue #, if available:
#256

Description of changes:
rename the variable desc_list.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

igorborgest
igorborgest approved these changes May 23, 2020
View reviewed changes
Copy link
Contributor

@igorborgest igorborgest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@igorborgest igorborgest self-assigned this May 23, 2020
@igorborgest igorborgest added the enhancement New feature or request label May 23, 2020
@igorborgest igorborgest merged commit 73b89c5 into aws:dev May 23, 2020
@bryanyang0528 bryanyang0528 deleted the fixed_confusing_variable branch May 29, 2020 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@igorborgest igorborgest igorborgest approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@igorborgest igorborgest

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bryanyang0528 @igorborgest