Partition columns now have correct type #27
Conversation
Previously all partition columns where of the string type. The same logic for non partition columns is reused to find out the type of the partition column,
|
@igorborgest I have some issue understanding how to best add tests for this. Could you point me in the right direction? |
|
Hey @stijndehaes! Awesome idea! Let's do that! Your implementation is pretty good, and works fine in my tests here. I've already organized that forking your fork and submitted a PR for your branch. |
|
@stijndehaes, regarding the tests: This project requires some setup for tests, and we tried to explain that here. But basically, we must have a AWS environment (Cloudformation) and a local environment (Docker). Almost all tests are about end-to-end integrations between AWS and Local. So after the setup of both ends, you only need to add test cases on testing/test_awswrangler. |
Updating branch, resolving conflicts, adding more tests
|
@igorborgest I will try to set it up and execute them tomorrow :) |
2 participants
Previously all partition columns where of the string type. The same
logic for non partition columns is reused to find out the type of the
partition column.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.