Skip to content

fix: trickle down s3_output in athena.to_iceberg #2767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2024
Merged

fix: trickle down s3_output in athena.to_iceberg #2767

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14f0377
fix: trickle down s3_output in to_iceberg
jaidisido Apr 9, 2024
3bec6cc
Merge branch 'main' into fix/missing-s3-output
jaidisido Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions awswrangler/athena/_write_iceberg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ def _create_iceberg_table(
index: bool = False,
data_source: str | None = None,
workgroup: str | None = None,
s3_output: str | None = None,
encryption: str | None = None,
kms_key: str | None = None,
boto3_session: boto3.Session | None = None,
Expand Down Expand Up @@ -73,6 +74,7 @@ def _create_iceberg_table(
wg_config=wg_config,
database=database,
data_source=data_source,
s3_output=s3_output,
encryption=encryption,
kms_key=kms_key,
boto3_session=boto3_session,
Expand Down Expand Up @@ -143,6 +145,7 @@ def _alter_iceberg_table(
wg_config: _WorkGroupConfig,
data_source: str | None = None,
workgroup: str | None = None,
s3_output: str | None = None,
encryption: str | None = None,
kms_key: str | None = None,
boto3_session: boto3.Session | None = None,
Expand Down Expand Up @@ -174,6 +177,7 @@ def _alter_iceberg_table(
wg_config=wg_config,
database=database,
data_source=data_source,
s3_output=s3_output,
encryption=encryption,
kms_key=kms_key,
boto3_session=boto3_session,
Expand Down Expand Up @@ -400,6 +404,7 @@ def to_iceberg(
index=index,
data_source=data_source,
workgroup=workgroup,
s3_output=s3_output,
encryption=encryption,
kms_key=kms_key,
boto3_session=boto3_session,
Expand Down Expand Up @@ -441,6 +446,7 @@ def to_iceberg(
wg_config=wg_config,
data_source=data_source,
workgroup=workgroup,
s3_output=s3_output,
encryption=encryption,
kms_key=kms_key,
boto3_session=boto3_session,
Expand Down