Skip to content

Conversation

@DavidKatz-il
Copy link
Contributor

Feature or Bugfix

  • Feature

Detail

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jaidisido
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 1f49b03
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: 1f49b03
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 9da6c5e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking
Copy link
Contributor

Hi @DavidKatz-il looks like formatting is off (run fix.sh to correct and validate.sh to validate), other than that - looks great!

@DavidKatz-il
Copy link
Contributor Author

Hi @DavidKatz-il looks like formatting is off (run fix.sh to correct and validate.sh to validate), other than that - looks great!

Done, the mypy check is still failing on code that I did not modify.

@jaidisido
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: cfa86ee
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: 9da6c5e
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking
Copy link
Contributor

That is fixed @DavidKatz-il , thanks for your contribution!

@kukushking kukushking merged commit 2e17ae9 into aws:main Oct 16, 2025
20 checks passed
@DavidKatz-il DavidKatz-il deleted the feat/result-reuse-configuration branch October 16, 2025 14:35
@DavidKatz-il
Copy link
Contributor Author

That is fixed @DavidKatz-il , thanks for your contribution!

Thanks, you can close the related ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants