Skip to content

Conversation

@maxispeicher
Copy link
Contributor

Issue #551:

Description of changes: Convert Jupyter Notebooks to HTML during documentation build for a static version of the tutorials with the help of nbsphinx and nbsphinx-link.
Right now the links in the docstrings point to 2.4.0-docs where the tutorial notebooks do not exist right now, but with the next release and a substitution of 2.4.0-docs to 2.5.0-docs everything should be linked just fine (a little chicken egg problem).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@igorborgest igorborgest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@igorborgest igorborgest self-assigned this Feb 25, 2021
@igorborgest igorborgest added the documentation Improvement or bugfixes on docs label Feb 25, 2021
@igorborgest
Copy link
Contributor

is it ready, right?

@maxispeicher
Copy link
Contributor Author

Yes 👍

@igorborgest igorborgest merged commit d9cc5f2 into aws:main Feb 25, 2021
@igorborgest
Copy link
Contributor

igorborgest commented Feb 25, 2021

It is already available on the "latest" and will be move to "stable" in the next release!

https://aws-data-wrangler.readthedocs.io/en/latest/

Thanks!

@maxispeicher maxispeicher deleted the generate-html-doc-for-notebooks branch February 26, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvement or bugfixes on docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants