Add flag for using column names in to_sql #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igorborgest
suggested changes
Mar 9, 2021
Contributor
igorborgest
left a comment
igorborgest
left a comment
There was a problem hiding this comment.
Seems great @maxispeicher !
You just need to replace "test" by "public" on the Redshift test case.
igorborgest
approved these changes
Mar 9, 2021
Contributor
igorborgest
left a comment
igorborgest
left a comment
There was a problem hiding this comment.
Thanks @maxispeicher !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #545:
Description of changes:
Add a flag for using the column names of the DataFrame in
to_sqlofmysql,postgresql,sqlserverandredshiftfor the creation of theINSERT INTOquery. When the flag is set toFalse(the default), the behavior will stay the same, but when it is set toTrue, data will only be inserted into columns which exist in the DataFrame.PS: @igorborgest Could you maybe run the new Redshift test as Redshift is unfortunately not available in AWS Educate.
sqlserver,postgresqlandmysqlare tested.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.