Add exist_ok flag to create_database #645
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
jaidisido
left a comment
jaidisido
left a comment
There was a problem hiding this comment.
Looks great, left a couple of suggestions
jaidisido
added
enhancement
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| if description is not None: | ||
| args["Description"] = description | ||
|
|
||
| if catalog_id is not None: |
There was a problem hiding this comment.
Why was this conditional removed?
There was a problem hiding this comment.
By using https://github.com/awslabs/aws-data-wrangler/blob/main/awswrangler/catalog/_utils.py#L17 in the create_database call, the catalog id is used for the creation if it is given but not used otherwise. Thereby the check is not required but included directly in the create call.
There was a problem hiding this comment.
Hmm I figured so but wanted to double check with you. Thanks @maxispeicher :)
3 participants
Issue #642:
Description of changes:
Before trying to create a new glue database,
awswranglernow checks if the database already exists. Ifexist_okis set toFalseand a database with the same name exists, an Exception is raised. Ifexist_okis set toTrueand the given description is different than the existing one it is updated.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.