Skip to content

Conversation

@maxispeicher
Copy link
Contributor

Issue #672 :

Description of changes:
Adding serde_library and serde_parameters to catalog.create_csv_table for the possibility to use a different serialization library (OpenCSV) with the appropiate SerDe properties.
Default behavior wasn't changed.

Additional fix for skip_header_line_count to actually use the number given and not always 1.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jaidisido
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-sDRE8Pq0duHT
  • Commit ID: 99e92cd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@maxispeicher maxispeicher marked this pull request as ready for review May 1, 2021 13:11
@jaidisido jaidisido added enhancement New feature or request minor release Will be addressed in the next minor release ready to release labels May 3, 2021
@jaidisido jaidisido added this to the 2.8.0 milestone May 3, 2021
@jaidisido
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-sDRE8Pq0duHT
  • Commit ID: e0004e7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido jaidisido merged commit ca73c19 into aws:main May 3, 2021
@jaidisido
Copy link
Contributor

Great stuff, thanks @maxispeicher!

@maxispeicher maxispeicher deleted the add_possibility_to_change_serde_info branch May 3, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request minor release Will be addressed in the next minor release ready to release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add ability to read double-quoted csvs to wr.catalog.create_csv_table()

2 participants