Add header support for CSV datasets #784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaidisido
requested changes
Jun 30, 2021
| wr.s3.read_csv(path=paths, iterator=True) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("header", [True, ["identifier"]]) |
Contributor
There was a problem hiding this comment.
My understanding is that the code change you made only applies when there is a database and table specified as params in the call. Yet the to_csv call in this test does not reference a Glue table. Should we test that instead? Also can we check that if we make more than one to_csv call to the same Glue table and read it back there isn't a duplicate header line in the resulting dataframe?
Contributor
Author
There was a problem hiding this comment.
Good catch, completely forgot about that in the test. I changed the test case + added a new one testing multiple modes.
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
jaidisido
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #765
Description of changes:
Add header support for CSV datasets.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.