Skip to content

CTAS table delete #797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 6, 2021
Merged

CTAS table delete #797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
986ff48
Deleting in correct database
jaidisido Jul 5, 2021
88f566e
Upgrading dependencies
jaidisido Jul 6, 2021
4cadee3
Merge branch 'main' into bug-782-ctas-perms
jaidisido Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion awswrangler/athena/_read.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,9 @@ def _resolve_query_without_cache(
boto3_session=boto3_session,
)
finally:
catalog.delete_table_if_exists(database=database, table=name, boto3_session=boto3_session)
catalog.delete_table_if_exists(
database=ctas_database_name or database, table=name, boto3_session=boto3_session
)
return _resolve_query_without_cache_regular(
sql=sql,
database=database,
Expand Down
2 changes: 1 addition & 1 deletion tests/test_athena.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def test_athena_ctas(path, path2, path3, glue_table, glue_table2, glue_database,
ctas_temp_table_name=glue_table2,
s3_output=path3,
)
assert wr.catalog.does_table_exist(database=glue_ctas_database, table=glue_table2) is True
assert wr.catalog.does_table_exist(database=glue_ctas_database, table=glue_table2) is False
assert len(wr.s3.list_objects(path=path3)) > 2
assert len(wr.s3.list_objects(path=final_destination)) > 0
for df in dfs:
Expand Down