Add schema evolution to s3.to_csv #799
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
jaidisido
reviewed
Jul 7, 2021
Comment on lines
+483
to
+492
|
|
||
| columns_types: Dict[str, str] = {} | ||
| partitions_types: Dict[str, str] = {} | ||
| if (database is not None) and (table is not None): | ||
| columns_types, partitions_types = _data_types.athena_types_from_pandas_partitioned( | ||
| df=df, index=index, partition_cols=partition_cols, dtype=dtype, index_left=True | ||
| ) | ||
| if schema_evolution is False: | ||
| _check_schema_changes(columns_types=columns_types, table_input=catalog_table_input, mode=mode) | ||
|
|
Contributor
There was a problem hiding this comment.
Why was it necessary to move this block outside the existing if condition for database and table on line 499? Mostly asking because it's likely to create a conflict with my Governed table branch which I would prefer to avoid :)
Contributor
Author
There was a problem hiding this comment.
Hahah, yes, I wanted to do it before _to_dataset call which in some cases will send a request to delete the files; and right after df = df[columns] if columns else df which is right when we form a "final" dataframe that we should check for schema evolution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #787
Description of changes:
Add schema evolution check to
wr.s3.to_csvBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.