Add postgres upsert #811
Merged
Add postgres upsert #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
jaidisido
approved these changes
Jul 14, 2021
Contributor
jaidisido
left a comment
jaidisido
left a comment
There was a problem hiding this comment.
Looks great to me, many thanks for this @maxispeicher!
@kukushking will merge after your review
kukushking
reviewed
Jul 14, 2021
Contributor
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
kukushking
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #807:
Description of changes:
Adding
upsertsupport for postgres. However, in contrast tomysqlonly a singleupsertmode exists, as in my eyes it is the only one which makes sense in a generic way for postgres (still I'm open to extending the modes).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.