Skip to content

[WIP] move to poetry #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Aug 10, 2021
Merged

[WIP] move to poetry #831

merged 9 commits into from
Aug 10, 2021

Conversation

@maxispeicher
Copy link
Contributor

@maxispeicher maxispeicher commented Jul 23, 2021

Description of changes:
Moving from requirements files to poetry for managing dependencies.

For publishing credentials need to be configured according to https://python-poetry.org/docs/repositories/#configuring-credentials.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jaidisido
Copy link
Contributor

jaidisido commented Jul 23, 2021

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
  • Commit ID: b5aa6f9
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido
Copy link
Contributor

jaidisido commented Jul 23, 2021

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
  • Commit ID: 404a362
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido
Copy link
Contributor

jaidisido commented Jul 23, 2021

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
  • Commit ID: efccd25
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido
Copy link
Contributor

jaidisido commented Jul 23, 2021

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
  • Commit ID: 6adc612
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@maxispeicher maxispeicher marked this pull request as ready for review July 29, 2021 20:38
jaidisido
jaidisido reviewed Aug 10, 2021
View reviewed changes
Copy link
Contributor

@jaidisido jaidisido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this left a couple of comments.

One additional one is that the current docs/environment.yml has -e installation flag which expects a requirements.txt file that would not exist. Wonder if read the docs supports poetry in fact...

@jaidisido
Copy link
Contributor

jaidisido commented Aug 10, 2021

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
  • Commit ID: 3b000d6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido jaidisido changed the base branch from main to dependabot/pip/jupyterlab-3.1.4 August 10, 2021 11:40
@jaidisido jaidisido changed the base branch from dependabot/pip/jupyterlab-3.1.4 to main August 10, 2021 11:40
@jaidisido
Copy link
Contributor

jaidisido commented Aug 10, 2021

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
  • Commit ID: fc2c830
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido jaidisido reopened this Aug 10, 2021
@jaidisido jaidisido changed the base branch from main to main-governed-tables August 10, 2021 13:28
@jaidisido jaidisido changed the base branch from main-governed-tables to main August 10, 2021 13:28
@maxispeicher
Merge branch 'main' into move_to_poetry
886cf24 
# Conflicts:
#	requirements-dev.txt
#	requirements.txt
@jaidisido
Copy link
Contributor

jaidisido commented Aug 10, 2021

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
  • Commit ID: 886cf24
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido
Copy link
Contributor

jaidisido commented Aug 10, 2021

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
  • Commit ID: 3e5b90a
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido
Copy link
Contributor

jaidisido commented Aug 10, 2021

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-pDO66x4b9gEu
  • Commit ID: 3e5b90a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido jaidisido merged commit 1f4e5ef into aws:main Aug 10, 2021
@maxispeicher maxispeicher deleted the move_to_poetry branch August 10, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaidisido jaidisido jaidisido left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maxispeicher @jaidisido