Skip to content

Improving Sagemaker module #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 2, 2020
Merged

Improving Sagemaker module #92

merged 2 commits into from
Jan 2, 2020

Conversation

@igorborgest
Copy link
Contributor

@igorborgest igorborgest commented Dec 31, 2019

Improving Sagemaker module.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@igorborgest igorborgest added the enhancement New feature or request label Dec 31, 2019
@igorborgest igorborgest requested review from a team and danielgoldszmit December 31, 2019 21:51
@igorborgest igorborgest self-assigned this Dec 31, 2019
@igorborgest
Copy link
Contributor Author

igorborgest commented Dec 31, 2019

image

🚀

@igorborgest igorborgest merged commit 21de8b1 into master Jan 2, 2020
@igorborgest igorborgest deleted the sagemaker branch January 2, 2020 02:05
tuliocasagrande
tuliocasagrande reviewed Jan 2, 2020
View reviewed changes
Copy link
Contributor

@tuliocasagrande tuliocasagrande left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edit: this won't work at least with XGBoost.

Tested with XGBoost 0.90-1.

tuliocasagrande
tuliocasagrande reviewed Jan 2, 2020
View reviewed changes
@igorborgest
Copy link
Contributor Author

igorborgest commented Jan 3, 2020

#96

dgoldszm
dgoldszm reviewed Jan 3, 2020
View reviewed changes
Copy link

@dgoldszm dgoldszm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like a wonderfull feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielgoldszmit danielgoldszmit Awaiting requested review from danielgoldszmit

2 more reviewers

@tuliocasagrande tuliocasagrande tuliocasagrande left review comments

@dgoldszm dgoldszm dgoldszm left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@igorborgest igorborgest

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@igorborgest @tuliocasagrande @dgoldszm