Skip to content

Commit 88fa5c4

Browse files
authored
Merge pull request #71 from diehlaws/common-files-standardization
Updating common files
2 parents aba3791 + 554a4dc commit 88fa5c4

File tree

3 files changed

+152
-5
lines changed

3 files changed

+152
-5
lines changed

CODE_OF_CONDUCT.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
## Code of Conduct
2+
This project has adopted the [Amazon Open Source Code of Conduct](https://aws.github.io/code-of-conduct).
3+
For more information see the [Code of Conduct FAQ](https://aws.github.io/code-of-conduct-faq) or contact
4+
opensource-codeofconduct@amazon.com with any additional questions or comments.

CONTRIBUTING.md

Lines changed: 113 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,113 @@
1+
# Contributing to the AWS Service Provider for Symfony
2+
3+
Thank you for your interest in contributing the AWS Service Provider for Symfony!
4+
We work hard to provide a high-quality and useful SDK for our AWS services, and
5+
we greatly value feedback and contributions from our community. Whether it's a
6+
new feature, correction, or additional documentation, we welcome your pull requests.
7+
Please submit your [issues][] or [pull requests][pull-requests] through GitHub.
8+
9+
Jump To:
10+
11+
* [Bug Reports](_#Bug-Reports_)
12+
* [Feature Requests](_#Feature-Requests_)
13+
* [Code Contributions](_#Code-Contributions_)
14+
15+
## How to contribute
16+
17+
*Before you send us a pull request, please be sure that:*
18+
19+
1. You're working from the latest source on the master branch.
20+
2. You check existing open, and recently closed, pull requests to be sure that
21+
someone else hasn't already addressed the problem.
22+
3. You create an issue before working on a contribution that will take a significant
23+
amount of your time.
24+
25+
*Creating a Pull Request*
26+
27+
1. Fork the repository.
28+
2. In your fork, make your change in a branch that's based on this repo's master branch.
29+
3. Commit the change to your fork, using a clear and descriptive commit message.
30+
4. Create a pull request, answering any questions in the pull request form.
31+
32+
For contributions that will take a significant amount of time, open a new issue to pitch
33+
your idea before you get started. Explain the problem and describe the content you want to
34+
see added to the documentation. Let us know if you'll write it yourself or if you'd like us
35+
to help. We'll discuss your proposal with you and let you know whether we're likely to
36+
accept it.
37+
38+
## Bug Reports
39+
40+
Bug reports are accepted through the [Issues][] page.
41+
42+
Before Submitting:
43+
44+
* Do a search through the existing issues to make sure it has not already been reported.
45+
If it has, comment your experience or +1 so we prioritize it.
46+
* If possible, upgrade to the latest release of the SDK. It's possible the bug has
47+
already been fixed in the latest version.
48+
49+
Writing the Bug Report:
50+
51+
Please ensure that your bug report has the following:
52+
53+
* A short, descriptive title. Ideally, other community members should be able to get a
54+
good idea of the issue just from reading the title.
55+
* A detailed description of the problem you're experiencing. This should include:
56+
* Expected behavior of the SDK and the actual behavior exhibited.
57+
* Any details of your application environment that may be relevant.
58+
* Debug information, stack trace or logs.
59+
* If you are able to create one, include a Minimal Working Example that reproduces the issue.
60+
* Use Markdown to make the report easier to read; i.e. use code blocks when pasting a
61+
code snippet.
62+
63+
## Feature Requests
64+
65+
Open an [issue][issues] with the following:
66+
67+
* A short, descriptive title. Ideally, other community members should be able to get a
68+
good idea of the feature just from reading the title.
69+
* A detailed description of the the proposed feature.
70+
* Why it should be added to the SDK.
71+
* If possible, example code to illustrate how it should work.
72+
* Use Markdown to make the request easier to read;
73+
* If you intend to implement this feature, indicate that you'd like to the issue to be assigned to you.
74+
75+
## Code Contributions
76+
77+
Code contributions to the SDK are done through [Pull Requests][pull-requests]. The list below are guidelines to use when submitting pull requests. These are the
78+
same set of guidelines that the core contributors use when submitting changes, and
79+
we ask the same of all community contributions as well:
80+
81+
1. The SDK is released under the [Apache license][license]. Any code you submit
82+
will be released under that license. For substantial contributions, we may
83+
ask you to sign a [Contributor License Agreement (CLA)][cla].
84+
2. We follow all of the relevant PSR recommendations from the [PHP Framework
85+
Interop Group][php-fig]. Please submit code that follows these standards.
86+
The [PHP CS Fixer][cs-fixer] tool can be helpful for formatting your code.
87+
3. We maintain a high percentage of code coverage in our unit tests. If you make
88+
changes to the code, please add, update, and/or remove tests as appropriate.
89+
4. Static code analysis with [PHPStan][phpstan] is automatically run on the `src`
90+
directory for submitted pull requests. If there is a case that needs to be
91+
ignored by static analysis, please update the `ignoreErrors` section in the
92+
`phpstan.neon` config file in your PR, and point out why this case warrants
93+
ignoring.
94+
5. If your code does not conform to the PSR standards, does not include adequate
95+
tests, or does not contain a changelog document, we may ask you to update
96+
your pull requests before we accept them. We also reserve the right to deny
97+
any pull requests that do not align with our standards or goals.
98+
6. If you would like to implement support for a significant feature that is not
99+
yet available in the SDK, please talk to us beforehand to avoid any
100+
duplication of effort.
101+
7. If you are working on the SDK, make sure to check out the `Makefile` for some
102+
of the common tasks that we have to do.
103+
104+
105+
[issues]: https://github.com/aws/aws-sdk-php-symfony/issues
106+
[pull-requests]: https://github.com/aws/aws-sdk-php-symfony/pulls
107+
[license]: http://aws.amazon.com/apache2.0/
108+
[cla]: https://github.com/aws/aws-cla/blob/master/amazon-single-contribution-license.txt
109+
[php-fig]: http://php-fig.org
110+
[cs-fixer]: http://cs.sensiolabs.org/
111+
[phpstan]: https://github.com/phpstan/phpstan
112+
[sphinx]: http://sphinx-doc.org/
113+
[restructuredtext]: http://sphinx-doc.org/rest.html

README.md

Lines changed: 35 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,15 @@
77

88
A Symfony bundle for including the [AWS SDK for PHP](https://github.com/aws/aws-sdk-php).
99

10-
## Installation
10+
Jump To:
11+
* [Getting Started](_#Getting-Started_)
12+
* [Getting Help](_#Getting-Help_)
13+
* [Contributing](_#Contributing_)
14+
* [More Resources](_#Resources_)
15+
16+
## Getting Started
17+
18+
### Installation
1119

1220
The AWS bundle can be installed via [Composer](http://getcomposer.org) by
1321
requiring the`aws/aws-sdk-php-symfony` package in your project's `composer.json`:
@@ -36,7 +44,7 @@ class AppKernel extends Kernel
3644
}
3745
```
3846

39-
## Configuration
47+
### Configuration
4048

4149
By default, configuration is handled by the SDK rather than by the bundle, and
4250
no validation is performed at compile time. Full documentation of the
@@ -55,7 +63,7 @@ you will need to escape it by adding another `@` sign.
5563

5664
Sample configuration can be found in the `tests/fixtures` folder for [YAML](https://github.com/aws/aws-sdk-php-symfony/blob/master/tests/fixtures/config.yml), [PHP](https://github.com/aws/aws-sdk-php-symfony/blob/master/tests/fixtures/config.php), and [XML](https://github.com/aws/aws-sdk-php-symfony/blob/master/tests/fixtures/config.xml).
5765

58-
### Sample YML Configuration
66+
#### Sample YML Configuration
5967

6068
The sample configuration which can be placed in `app/config/config.yml` file.
6169

@@ -85,7 +93,8 @@ services:
8593
- a-different-fake-key
8694
- a-different-fake-secret
8795
```
88-
## Usage
96+
97+
### Usage
8998
9099
This bundle exposes an instance of the `Aws\Sdk` object as well as instances of
91100
each AWS client object as services to your symfony application. They are name
@@ -109,7 +118,28 @@ php bin/console debug:container aws
109118
Full documentation on each of the services listed can be found in the [SDK API
110119
docs](http://docs.aws.amazon.com/aws-sdk-php/v3/api/).
111120

112-
## Links
121+
## Getting Help
122+
123+
Please use these community resources for getting help. We use the GitHub issues for tracking bugs and feature requests and have limited bandwidth to address them.
124+
125+
* Ask a question on [StackOverflow](https://stackoverflow.com/) and tag it with [`aws-php-sdk`](http://stackoverflow.com/questions/tagged/aws-php-sdk)
126+
* Come join the AWS SDK for PHP [gitter](https://gitter.im/aws/aws-sdk-php)
127+
* Open a support ticket with [AWS Support](https://console.aws.amazon.com/support/home/)
128+
* If it turns out that you may have found a bug, please [open an issue](https://github.com/aws/aws-sdk-php-symfony/issues/new/choose)
129+
130+
This SDK implements AWS service APIs. For general issues regarding the AWS services and their limitations, you may also take a look at the [Amazon Web Services Discussion Forums](https://forums.aws.amazon.com/).
131+
132+
### Opening Issues
133+
134+
If you encounter a bug with `aws-sdk-php-symfony` we would like to hear about it. Search the existing issues and try to make sure your problem doesn’t already exist before opening a new issue. It’s helpful if you include the version of `aws-sdk-php-symfony`, PHP version and OS you’re using. Please include a stack trace and reduced repro case when appropriate, too.
135+
136+
The GitHub issues are intended for bug reports and feature requests. For help and questions with using `aws-sdk-php` please make use of the resources listed in the Getting Help section. There are limited resources available for handling issues and by keeping the list of open issues lean we can respond in a timely manner.
137+
138+
## Contributing
139+
140+
We work hard to provide a high-quality and useful SDK for our AWS services, and we greatly value feedback and contributions from our community. Please review our [contributing guidelines](./CONTRIBUTING.md) before submitting any issues or pull requests to ensure we have all the necessary information to effectively respond to your bug report or contribution.
141+
142+
## Resources
113143

114144
* [AWS SDK for PHP on Github](http://github.com/aws/aws-sdk-php)
115145
* [AWS SDK for PHP website](http://aws.amazon.com/sdkforphp/)

0 commit comments

Comments
 (0)