Releasing 2.6.0 #165
Merged
Releasing 2.6.0 #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhautikpip
requested review from
anuraaga,
shengxil and
willarmiros
as code owners
anuraaga
approved these changes
Jun 9, 2020
Contributor
anuraaga
left a comment
anuraaga
left a comment
There was a problem hiding this comment.
LGTM with one note that we can probably trim down the changelog
CHANGELOG.md
Outdated
| [PR 150](https://github.com/aws/aws-xray-sdk-java/pull/150) | ||
| - Modified exception handling in UDPEmitter | ||
| [PR 151](https://github.com/aws/aws-xray-sdk-java/issues/151) | ||
| - Added gradle build configuration |
Contributor
There was a problem hiding this comment.
I would leave out build tooling notes from the ChangeLog they aren't really relevant to users of the library. So everything about Gradle and the various plugins and JMH version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR introduces release commit which includes changes in changelog, version updates in pom.xml and benchmark README changes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.